Added description of remaining endpoints of the gcbm api and resolved typos in the readme #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AayushSaini101 <[email protected]>
Signed-off-by: AayushSaini101 <[email protected]>
Signed-off-by: AayushSaini101 <[email protected]>
Signed-off-by: AayushSaini101 <[email protected]>
Signed-off-by: AayushSaini101 <[email protected]>
Signed-off-by: AayushSaini101 <[email protected]>
Signed-off-by: AayushSaini101 <[email protected]>
Signed-off-by: AayushSaini101 <[email protected]>
| @@ -342,6 +342,8 @@ def gcbm_download(): | |||
| # Sanitize title | |||
| title = "".join(c for c in title if c.isalnum()) | |||
| project_dir = f"{title}" | |||
| if not os.path.exists(f"{os.getcwd()}/input/{project_dir}"): | |||
| return {"error": "No such simulation exist for this {title}"}, 400 | |||
There was a problem hiding this comment.
I think the error status code, can be changed to 404 as 400 is used for a bad request and 404 is for a not found error. Let me know your thoughts on this.
There was a problem hiding this comment.
I think 404 is valid here because the simulation of the given title is not present. @padmajabhol What are your views on this issue.
padmajabhol
requested changes
Jun 9, 2022
Signed-off-by: AayushSaini101 <[email protected]>
|
@padmajabhol Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added description of remaining endpoints of the gcbm api and resolved typos in the readme.